Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let standard limiters to work when standalone not enabled #3001

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-18 14:33:45

Comparing candidate commit df1afe5 in PR branch estringana/change-rate-limiter-standalone with baseline commit 0926c77 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-15.856µs; -14.722µs] or [-8.128%; -7.547%]

@estringana estringana force-pushed the estringana/change-rate-limiter-standalone branch from fc0d9d3 to 0f87461 Compare December 17, 2024 12:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (0926c77) to head (334b27b).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3001      +/-   ##
============================================
- Coverage     72.74%   72.72%   -0.02%     
  Complexity     2750     2750              
============================================
  Files           138      138              
  Lines         15060    15060              
  Branches       1026     1026              
============================================
- Hits          10955    10953       -2     
- Misses         3546     3548       +2     
  Partials        559      559              
Flag Coverage Δ
appsec-extension 67.95% <ø> (ø)
tracer-php 74.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0926c77...334b27b. Read the comment docs.

@estringana estringana force-pushed the estringana/change-rate-limiter-standalone branch from 0f87461 to df1afe5 Compare December 17, 2024 14:15
@estringana estringana marked this pull request as ready for review December 17, 2024 16:17
@estringana estringana requested review from a team as code owners December 17, 2024 16:17
@estringana estringana force-pushed the estringana/change-rate-limiter-standalone branch from 334b27b to df1afe5 Compare December 18, 2024 14:04
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana merged commit 0d57b55 into master Dec 18, 2024
737 of 768 checks passed
@estringana estringana deleted the estringana/change-rate-limiter-standalone branch December 18, 2024 15:26
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants